# changelog

author: Open vSwitch CI <ovs-ci@redhat.com> - 2.13.0-130
changelog:
  - Merging upstream branch-2.13 [RH git: beb8cdaec6]
      Commit list:
      ceb395773d dpif-netdev: Fix use-after-free on PACKET_OUT of IP fragments.
      fed4df9bb7 tunnel-push-pop.at: Mask source port in tunnel header.


author: Open vSwitch CI <ovs-ci@redhat.com> - 2.13.0-131
changelog:
  - Merging upstream branch-2.13 [RH git: 31c65d3e94]
      Commit list:
      6e2e180851 ofproto-dpif-xlate: Fix zone set from non-frozen-metadata fields.


author: Open vSwitch CI <ovs-ci@redhat.com> - 2.13.0-132
changelog:
  - Merging upstream branch-2.13 [RH git: 60a72ee3f6]
      Commit list:
      5c33e4db80 datapath-windows: add layers when adding the deferred actions


author: Open vSwitch CI <ovs-ci@redhat.com> - 2.13.0-133
changelog:
  - Merging upstream branch-2.13 [RH git: d37b008459]
      Commit list:
      70f6efa41c python: idl: Avoid sending transactions when the DB is not synced up.


author: Open vSwitch CI <ovs-ci@redhat.com> - 2.13.0-134
changelog:
  - Merging upstream branch-2.13 [RH git: c72ff28f03]
      Commit list:
      4d5470a450 Prepare for 2.13.6.
      6771b9c9d7 Set release date for 2.13.5.


author: Open vSwitch CI <ovs-ci@redhat.com> - 2.13.0-135
changelog:
  - Merging upstream branch-2.13 [RH git: 1b6734e549]
      Commit list:
      b73ad3bcf7 ci: Make linux-prepare trust system installs.


author: Open vSwitch CI <ovs-ci@redhat.com> - 2.13.0-136
changelog:
  - Merging upstream branch-2.13 [RH git: 25cc09c60a]
      Commit list:
      2c1369aa6d netdev-offload-tc: Verify the flower rule installed.


author: Open vSwitch CI <ovs-ci@redhat.com> - 2.13.0-137
changelog:
  - Merging upstream branch-2.13 [RH git: f86ccc67c2]
      Commit list:
      da5b115580 datapath-windows:Reset PseudoChecksum value only for TX direction offload case


author: Open vSwitch CI <ovs-ci@redhat.com> - 2.13.0-138
changelog:
  - Merging upstream branch-2.13 [RH git: 424b25f9ca]
      Commit list:
      85358e0a9f datapath-windows: Reset flow key after Ipv4 fragments are reassembled


author: Open vSwitch CI <ovs-ci@redhat.com> - 2.13.0-139
changelog:
  - Merging upstream branch-2.13 [RH git: 37c2767bbd]
      Commit list:
      057a5b0708 ofproto-dpif-xlate: Fix check_pkt_larger incomplete translation.


author: Open vSwitch CI <ovs-ci@redhat.com> - 2.15.0-43
changelog:
  - Merging upstream branch-2.15 [RH git: 09e3ab3630]
      Commit list:
      9efa2ea619 ipf: release unhandled packets from the batch


author: Open vSwitch CI <ovs-ci@redhat.com> - 2.15.0-44
changelog:
  - Merging upstream branch-2.15 [RH git: 3050e5222d]
      Commit list:
      58397f222b dpdk-stub: Change the ERR log to DBG.
      2a963fc314 python: idl: Avoid sending transactions when the DB is not synced up.


author: Open vSwitch CI <ovs-ci@redhat.com> - 2.15.0-45
changelog:
  - Merging upstream branch-2.15 [RH git: e273e307d1]
      Commit list:
      ea2ca0af16 dpif-netdev: Fix use-after-free on PACKET_OUT of IP fragments.
      9f964354e3 tunnel-push-pop.at: Mask source port in tunnel header.


author: Open vSwitch CI <ovs-ci@redhat.com> - 2.15.0-46
changelog:
  - Merging upstream branch-2.15 [RH git: f8619036c9]
      Commit list:
      3f718857e7 ofproto-dpif-xlate: Fix zone set from non-frozen-metadata fields.


author: Open vSwitch CI <ovs-ci@redhat.com> - 2.15.0-47
changelog:
  - Merging upstream branch-2.15 [RH git: 01110b9088]
      Commit list:
      b7d9c491ec datapath-windows: add layers when adding the deferred actions


author: Open vSwitch CI <ovs-ci@redhat.com> - 2.15.0-48
changelog:
  - Merging upstream branch-2.15 [RH git: 7cf784736e]
      Commit list:
      2cf63851a5 Prepare for 2.15.3.
      63f9a7c5d8 Set release date for 2.15.2.


author: Open vSwitch CI <ovs-ci@redhat.com> - 2.15.0-49
changelog:
  - Merging upstream branch-2.15 [RH git: 2502ca29b0]
      Commit list:
      952e851506 ci: Make linux-prepare trust system installs.


author: Open vSwitch CI <ovs-ci@redhat.com> - 2.15.0-50
changelog:
  - Merging upstream branch-2.15 [RH git: 16dad85706]
      Commit list:
      031cf67e09 netdev-offload-tc: Verify the flower rule installed.


author: Open vSwitch CI <ovs-ci@redhat.com> - 2.15.0-51
changelog:
  - Merging upstream branch-2.15 [RH git: a134a530c9]
      Commit list:
      eca2d50d40 datapath-windows:Reset PseudoChecksum value only for TX direction offload case


author: Open vSwitch CI <ovs-ci@redhat.com> - 2.15.0-52
changelog:
  - Merging upstream branch-2.15 [RH git: 001ae577c6]
      Commit list:
      08a270dda1 datapath-windows: Reset flow key after Ipv4 fragments are reassembled


author: Open vSwitch CI <ovs-ci@redhat.com> - 2.16.0-23
changelog:
  - Merging upstream branch-2.16 [RH git: cce913794e]
      Commit list:
      2a4c87f300 Prepare for 2.16.2.
      aaa1439b8e Set release date for 2.16.1.


author: Open vSwitch CI <ovs-ci@redhat.com> - 2.16.0-24
changelog:
  - Merging upstream branch-2.16 [RH git: 4682b76694]
      Commit list:
      b79f0369f2 ci: Make linux-prepare trust system installs.


author: Open vSwitch CI <ovs-ci@redhat.com> - 2.16.0-25
changelog:
  - Merging upstream branch-2.16 [RH git: f5366890c5]
      Commit list:
      c221c8e613 datapath-windows:Reset PseudoChecksum value only for TX direction offload case


author: Ilya Maximets <i.maximets@redhat.com> - 2.16.0-26
changelog:
  - ovsdb: transaction: Incremental reassessment of weak refs. [RH git: e8a363db49] (#2005958)
      commit 4dbff9f0a68579241ac1a040726be3906afb8fe9
      Author: Ilya Maximets <i.maximets@ovn.org>
      Date:   Sat Oct 16 03:20:23 2021 +0200
      
          ovsdb: transaction: Incremental reassessment of weak refs.
      
          The main idea is to not store list of weak references in the source
          row, so they all don't need to be re-checked/updated on every
          modification of that source row.  The point is that source row already
          knows UUIDs of all destination rows stored in the data, so there is no
          much profit in storing this information somewhere else.  If needed,
          destination row can be looked up and reference can be looked up in the
          destination row.  For the fast lookup, destination row now stores
          references in a hash map.
      
          Weak reference structure now contains the table and uuid of a source
          row instead of a direct pointer.  This allows to replace/update the
          source row without breaking any weak references stored in destination
          rows.
      
          Structure also now contains the key-value pair of atoms that triggered
          creation of this reference.  These atoms can be used to quickly
          subtract removed references from a source row.  During reassessment,
          ovsdb now only needs to care about new added or removed atoms, and
          atoms that got removed due to removal of the destination rows, but
          these are marked for reassessment by the destination row.
      
          ovsdb_datum_subtract() is used to remove atoms that points to removed
          or incorrect rows, so there is no need to re-sort datum in the end.
      
          Results of an OVN load-balancer benchmark that adds 3K load-balancers
          to each of 120 logical switches and 120 logical routers in the OVN
          sandbox with clustered Northbound database and then removes them:
      
          Before:
      
            %CPU  CPU Time  CMD
            86.8  00:16:05  ovsdb-server nb1.db
            44.1  00:08:11  ovsdb-server nb2.db
            43.2  00:08:00  ovsdb-server nb3.db
      
          After:
      
            %CPU  CPU Time  CMD
            54.9  00:02:58  ovsdb-server nb1.db
            33.3  00:01:48  ovsdb-server nb2.db
            32.2  00:01:44  ovsdb-server nb3.db
      
          So, on a cluster leader the processing time dropped by 5.4x, on
          followers - by 4.5x.  More load-balancers - larger the performance
          difference.  There is a slight increase of memory usage, because new
          reference structure is larger, but the difference is not significant.
      
          Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
          Acked-by: Dumitru Ceara <dceara@redhat.com>
      
      Reported-at: https://bugzilla.redhat.com/2005958
      Signed-off-by: Ilya Maximets <i.maximets@redhat.com>


author: Ilya Maximets <i.maximets@redhat.com> - 2.16.0-27
changelog:
  - ovsdb: Don't let transaction history grow larger than the database. [RH git: 93d1fa0bdf] (#2012949)
      commit 317b1bfd7dd315e241c158e6d4095002ff391ee3
      Author: Ilya Maximets <i.maximets@ovn.org>
      Date:   Tue Sep 28 13:17:21 2021 +0200
      
          ovsdb: Don't let transaction history grow larger than the database.
      
          If user frequently changes a lot of rows in a database, transaction
          history could grow way larger than the database itself.  This wastes
          a lot of memory and also makes monitor_cond_since slower than
          usual monotor_cond if the transaction id is old enough, because
          re-construction of the changes from a history is slower than just
          creation of initial database snapshot.  This is also the case if
          user deleted a lot of data, so transaction history still holds all of
          it while the database itself doesn't.
      
          In case of current lb-per-service model in ovn-kubernetes, each
          load-balancer is added to every logical switch/router.  Such a
          transaction touches more than a half of a OVN_Northbound database.
          And each of these transactions is added to the transaction history.
          Since transaction history depth is 100, in worst case scenario,
          it will hold 100 copies of a database increasing memory consumption
          dramatically.  In tests with 3000 LBs and 120 LSs, memory goes up
          to 3 GB, while holding at 30 MB if transaction history disabled in
          the code.
      
          Fixing that by keeping count of the number of ovsdb_atom's in the
          database and not allowing the total number of atoms in transaction
          history to grow larger than this value.  Counting atoms is fairly
          cheap because we don't need to iterate over them, so it doesn't have
          significant performance impact.  It would be ideal to measure the
          size of individual atoms, but that will hit the performance.
          Counting cells instead of atoms is not sufficient, because OVN
          users are adding hundreds or thousands of atoms to a single cell,
          so they are largely different in size.
      
          Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
          Acked-by: Han Zhou <hzhou@ovn.org>
          Acked-by: Dumitru Ceara <dceara@redhat.com>
      
      Reported-at: https://bugzilla.redhat.com/2012949
      Signed-off-by: Ilya Maximets <i.maximets@redhat.com>


author: Timothy Redaelli <tredaelli@redhat.com> - 2.16.0-29
changelog:
  - python: socket-util: Split inet_open_active function and use connect_ex. [RH git: 2e704b371c]
      In an upcoming patch, PyOpenSSL will be replaced with Python ssl module,
      but in order to do an async connection with Python ssl module the ssl
      socket must be created when the socket is created, but before the
      socket is connected.
      
      So, inet_open_active function is splitted in 3 parts:
      - inet_create_socket_active: creates the socket and returns the family and
        the socket, or (error, None) if some error needs to be returned.
      - inet_connect_active: connect the socket and returns the errno (it
        returns 0 if errno is EINPROGRESS or EWOULDBLOCK).
      
      connect is replaced by connect_ex, since Python suggest to use it for
      asynchronous connects and it's also cleaner since inet_connect_active
      returns errno that connect_ex already returns, moreover due to a Python
      limitation connect cannot not be used with ssl module.
      
      inet_open_active function is changed in order to use the new functions
      inet_create_socket_active and inet_connect_active.
      
      Signed-off-by: Timothy Redaelli <tredaelli@redhat.com>
      Acked-by: Terry Wilson <twilson@redhat.com>
      Tested-by: Terry Wilson <twilson@redhat.com>
      Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
      Signed-off-by: Timothy Redaelli <tredaelli@redhat.com>


author: Timothy Redaelli <tredaelli@redhat.com> - 2.16.0-30
changelog:
  - python: Replace pyOpenSSL with ssl. [RH git: 0cd5867531] (#1988429)
      Currently, pyOpenSSL is half-deprecated upstream and so it's removed on
      some distributions (for example on CentOS Stream 9,
      https://issues.redhat.com/browse/CS-336), but since OVS only
      supports Python 3 it's possible to replace pyOpenSSL with "import ssl"
      included in base Python 3.
      
      Stream recv and send had to be splitted as _recv and _send, since SSLError
      is a subclass of socket.error and so it was not possible to except for
      SSLWantReadError and SSLWantWriteError in recv and send of SSLStream.
      
      TCPstream._open cannot be used in SSLStream, since Python ssl module
      requires the SSL socket to be created before connecting it, so
      SSLStream._open needs to create the socket, create SSL socket and then
      connect the SSL socket.
      
      Reported-by: Timothy Redaelli <tredaelli@redhat.com>
      Reported-at: https://bugzilla.redhat.com/1988429
      Signed-off-by: Timothy Redaelli <tredaelli@redhat.com>
      Acked-by: Terry Wilson <twilson@redhat.com>
      Tested-by: Terry Wilson <twilson@redhat.com>
      Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
      Signed-off-by: Timothy Redaelli <tredaelli@redhat.com>


author: Open vSwitch CI <ovs-ci@redhat.com> - 2.16.0-31
changelog:
  - Merging upstream branch-2.16 [RH git: 77a249d38b]
      Commit list:
      f8f2f7c9cb datapath-windows: Reset flow key after Ipv4 fragments are reassembled


author: Open vSwitch CI <ovs-ci@redhat.com> - 2.16.0-32
changelog:
  - Merging upstream branch-2.16 [RH git: e90e06a818]
      Commit list:
      1d8e0f861f ofproto-dpif-xlate: Fix check_pkt_larger incomplete translation.


